Use empty string instead of undefined in server id #3
+12
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In http2, `HeaderList` was replaced with `[Header]`, `SettingsHeaderTableSize` was replaced with `SettingsTokenHeaderTableSize`. - data-default 0.8 deprecates data-default-class by moving the `Default` class from `Data.Default.Class` to `Data.Default`. - tls has replaced some default instances with functions and made some record constructors private. See: haskell-grpc-native/http2-client#97 See: kazu-yamamoto/crypton-certificate#11 See: haskell-tls/hs-tls#486 See: commercialhaskell/stackage#7545
Update for http2-5.3 and upcoming tls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1 - required as base. Happy to rebase once that has been merged.
undefinedis evaluated for us in certain cases with the TLS upgrade resulting in our push notifications not sending. This replaces undefined with an empty string in the server id